Why isn't this code compiling?

general
1

Please help in finding what’s wrong with this piece of code

#include< bits/stdc++.h >
using namespace std;

map< string,int > mp;
map< string,int > present;

int minChars(string& s,int i,int j)
{
	if(i>=j)
		return 0;
	if(s[i]==s[j])
		return minChars(s,i+1,j-1);
	else
	{
		if(present[s])
			return mp[s];
		else
		{
			string a=s[j]+s.substr(i,j-i+1);
			string b=s.substr(i,j-i+1)+s[i];
			int p,q,r,s;
			p=r=0;
			q=a.length()-1;
			s=b.length()-1;
			mp[s]=min(1+minChars(a,p,q),1+minChars(b,r,s));
			present[s]=1;
			return mp[s];
		}		
	}
}
int main()
{	
	int t;
	cin>>t;
	string s;
	while(t--)
	{
		cin>>s;
		int k=minChars(s,0,s.length()-1);
		cout<< k;
		cout<< endl;
	}
	return 0;
}


```
2

There are 2 errors (so it seems :D) :

  • It seems that we can’t use whitespace characters inside < and >.
  • There’s another integer variable with the same name (s) as that of the function parameter. Precisely, in line int p, q, r, s declares an integer s and then the string s is shadowed here.
1 Like
3

Thanks a ton bro, silly mistake I’ll take care of variable names from next time !!!

4

Glad to be of help :slight_smile: