Can somebody explain me what wrong with this approach

thanks