Can someone help me find bug in my code. It’s giving write answer for sample inputs but if I submit it says WA.
codechef.com/viewsolution/31077750
@amruth_rao Your code is giving wrong answers for the following cases:
15 1 3
167 181 479
475 58 441
999999999999 5 1
The output should be:
NO
YES
YES
YES
Now you can debug your code, your code has a small bug which you find out first and if you don’t get it after trying, then I will let you know.
Solution ?
Thankyou very much!!!
Also, what type of coding convention should i follow. Can you please elaborate.
Thanks
@prophet_james There are some principles which you need to follow which is being laid out by some top computer scientists, engineers, and software development advocates.
I have given some links, you can go through them.
One thing always keep in mind,
Anybody can write code which a computer can understand but great programmers write code which a normal person/programmer can also understand.
Thankyou for your help. I will go those those links and try to write more readable code in the future.
Thanks again
1 Like
what wrong with my logic?
problem smartphone.
#include <bits/stdc++.h>
using namespace std;
int main()
{
#define int long long int
int n;
int i,flag;
int sum,avg;
int ans,l;
cin>>n;
int a[n];
for(i=0;i<n;i++)
{
cin>>a[i];
sum=sum+a[i];
}
avg=sum/n;
flag=0;
sort(a,a+n);
for(i=0;i<n;i++)
{
if(flag!=1)
{ if(a[i]>=avg)
{ ans=a[i];
l=a[i];
flag=1;
}
}
else
{
if(a[i]>=avg)
ans=ans+l;
}
}
cout<<ans;
return 0;
}
- I applied a similar logic related to the pattern of 2,4,8,6.
- I ran a loop till the first occurrence of digit ‘2’ in the number and computed the sum till that position, for the rest of the digits(if any) i find the sum directly using sum of 2,4,8,6 and dividing the remaining digits by 4 and later modulo to find if anythings left.
- it is still giving a TLE. i dont understand why.
Here is a link to my code :
https://www.codechef.com/viewsolution/32334578
Hi,
Can you tell me what’s wrong in this code because it seems to be correct. But getting Runtime Error after submission. @striker22
My Java Code:
static long playGame(int ini, int n, int q) {
long headctr = 0, tailCtr = 0;
char[] charr = new char[n];
if(ini == 1)
Arrays.fill(charr,'H');
else
Arrays.fill(charr,'T');
for(int i=0; i<n; i++) {
for(int j=0; j<=i; j++) {
if(charr[j] == 'H')
charr[j] = 'T';
else
charr[j] = 'H';
}
}
for(int i=0; i<charr.length; i++) {
if(charr[i] == 'H') headctr++;
else tailCtr++;
}
return (q==1)?headctr:tailCtr;
}
Thanks 
Can you share your complete code?
1 Like
As mentioned earlier I am getting RTE for this code. @striker22
Complete Code:
import java.util.*;
import java.io.*;
class CoinFlip {
static long playGame(int ini, int n, int q) {
long headctr = 0, tailCtr = 0;
char[] charr = new char[n];
if(ini == 1)
Arrays.fill(charr,'H');
else
Arrays.fill(charr,'T');
for(int i=0; i<n; i++) {
for(int j=0; j<=i; j++) {
if(charr[j] == 'H')
charr[j] = 'T';
else
charr[j] = 'H';
}
}
for(int i=0; i<charr.length; i++) {
if(charr[i] == 'H') headctr++;
else tailCtr++;
}
return (q==1)?headctr:tailCtr;
}
public static void main(String[] args) {
Scanner sc = new Scanner(System.in);
int t = sc.nextInt();
while(t-- > 0) {
int ngames = sc.nextInt();
for(int i=0; i<ngames; i++) {
int initial = sc.nextInt(), roundCoins = sc.nextInt(), q = sc.nextInt();
System.out.println(playGame(initial, roundCoins, q));
}
}
}
}
I think you are getting Runtime Error because the value of N can be as large as 10^9 which I don’t think JAVA will be able to allocate.
When I ran your program I get the following message for the given test-case:
1
1
1 1000000000 1
Exception in thread "main" java.lang.OutOfMemoryError: Java heap space
at CoinFlip.playGame(coin_flip.java:11)
at CoinFlip.main(coin_flip.java:67)
NOTE: I am not a JAVA programmer, so I am not sure, but maybe that is the sure bug in your program.
Test-Cases: The following are the test-cases on which you can run your program, if you get the correct output, then you can be sure that your solution is correct.
Input:
7
2
1 5 1
1 5 2
2
1 1 1
2 1 1
2
1 3 1
2 3 1
2
1 4 1
2 4 1
5
2 5 1
2 5 2
1 1 2
2 1 2
2 4 2
1
1 1000000000 1
1
1 1000000000 2
Correct Output:
2
3
0
1
1
2
2
2
3
2
1
0
2
500000000
500000000
However, there is a O(1) time solution to the problem which I have already explained in the post Editorial for Problems of Codechef-DSA-Learning-Series: 1-Complexity Analysis + Basics Warm Up
1 Like
Thanks for your help
Here is my code of CARVANS. Please tell me about where I am wrong.
try:
a = int(input())
for i in range(a):
e = 0
b = int(input())
c = list(map(int, input().split()))
if(len(c) == 1):
print(1)
else:
for i in range(len(c)-1):
if(i == 0):
e += 1
elif(c[i] < c[i-1] and c[i] < c[i+1]):
e += 1
print(e)
except EOFError:
passFormat your code first as the forum software has messed it up. Refer to the following guide:
Can you please tell me whats wrong in this solution.
Your program is giving WA for the following case:
Test-Case:
5
12 45 23 33 120
Your Code Output:
2
Correct-Output:
1
Hope this helps you figure out your mistake.
My Solution (CodeChef: Practical coding for everyone) for MULTHREE is reporting NZEC. Please help me!
You are not handling the case when K = 2.
However even after you handle K = 2 case, your logic is not correct.
Your program even after handling the case for K = 2 is giving WA for the following test-cases:
Test-Cases:
5
864204528303 5 4
472253834783 7 7
636817857948 6 6
812926620342 5 3
329423582819 1 0
Your Program Output:
NO
YES
NO
YES
NO
Correct Output:
YES
NO
NO
NO
YES
I suggest you to have a look on the editorial for the problem as explained here, and update your source-code accordingly and then run on the test-cases mentioned here.
If you are getting correct answers for all the test-cases then you can claim that your solution is correct.